On Wed, Mar 08, 2023 at 12:14:34PM +0100, Michal Privoznik wrote: > Since qemuxml2argvtest is now using virnumamock, there's no need > for qemuxml2argvmock to offer reimplementation of virNuma*() > functions. Also, the comment about CLang and FreeBSD (introduced > in v4.3.0-40-g77ac204d14) is no longer true. Looks like noinline > attribute was the missing culprit. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/util/virnuma.h | 2 +- > ...-unavailable-restrictive.x86_64-latest.err | 2 +- > ...mnode-unavailable-strict.x86_64-latest.err | 2 +- > ...umatune-static-nodeset-exceed-hostnode.err | 2 +- > tests/qemuxml2argvmock.c | 41 ------------------- > 5 files changed, 4 insertions(+), 45 deletions(-) Double spaces in the commit message. Honestly I'm as baffled as to how this works as I was back when I introduced those mocks. The situation after your changes is clearly preferable to the hack that's currently there, so I'm more than happy to see them merged, under the assumption of course that you've already ensured that everything keeps working on non-Linux platforms by running a full GitLab CI pipeline. Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> -- Andrea Bolognani / Red Hat / Virtualization
