On Wed, Mar 08, 2023 at 12:14:29PM +0100, Michal Privoznik wrote: > +/** > + * virNumaNodesetToCPUset: > + * @nodeset: returned bitmap containing a set of NUMA nodes > + * @cpuset: bitmap containing a set of CPUs > + * > + * Convert a set of CPUs to set of NUMA nodes that contain the CPUs. > + * > + * Returns: 0 on success, > + * -1 on failure (with error reported) > + */ > +int > +virNumaCPUSetToNodeset(virBitmap **nodeset, > + virBitmap *cpuset) The name of the function in the docstring is wrong. Please also consider swapping the arguments, to match the name of the function and how the existing virNumaNodesetToCPUset() does it. -- Andrea Bolognani / Red Hat / Virtualization