On Wed, Mar 08, 2023 at 12:14:28PM +0100, Michal Privoznik wrote: > Technically, there's nothing libnuma specific about > virNumaNodesetToCPUset(). It just implements a generic algorithm > over virNumaGetNodeCPUs() (which is then libnuma dependant). > Nevertheless, there's no need to have this function living inside > WITH_NUMACTL block. Any error returned from virNumaGetNodeCPUs() > (including the one that !WITH_NUMACTL stub returns) is propagated > properly. > > Move the function out of the block into a generic one and drop > the !WITH_NUMACTL stub. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/util/virnuma.c | 115 +++++++++++++++++++++------------------------ > 1 file changed, 53 insertions(+), 62 deletions(-) Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> -- Andrea Bolognani / Red Hat / Virtualization
