On 2/13/23 22:45, Jim Fehlig wrote: > libxl added support for specifying custom firmware paths long ago. This series > adds support to the libxl driver and the XML to xl.cfg config converter. > > Jim Fehlig (2): > libxl: Support specifying a custom firmware path > libxl: Add support for custom firmware path in config converter > > src/libxl/libxl_conf.c | 14 ++-- > src/libxl/xen_xl.c | 19 +++-- > tests/libxlxml2domconfigdata/efi-hvm.json | 91 +++++++++++++++++++++++ > tests/libxlxml2domconfigdata/efi-hvm.xml | 36 +++++++++ > tests/libxlxml2domconfigtest.c | 1 + > tests/xlconfigdata/test-fullvirt-ovmf.cfg | 1 + > tests/xlconfigdata/test-fullvirt-ovmf.xml | 2 +- > 7 files changed, 150 insertions(+), 14 deletions(-) > create mode 100644 tests/libxlxml2domconfigdata/efi-hvm.json > create mode 100644 tests/libxlxml2domconfigdata/efi-hvm.xml > Ooops, this has slipped through the cracks even though I had it marked for review. Sorry. Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> BTW: what's your view on bumping minimal XEN version from 4.9 to at least 4.10 (or even something newer)? That way we could drop some code (at least). Michal