On Tue, Mar 07, 2023 at 08:22:25AM -0800, Mike Pontillo wrote:
On Tue, Mar 7, 2023, 00:59 Martin Kletzander <mkletzan@xxxxxxxxxx> wrote:Good catch, we can make it even slicker with: VIR_LOCK_GUARD lock = virLockGuardLock(&priv->lock); and rely on automatic unlock at the return. Either way (let me know if you're OK with the proposed change):Thanks for the review; I'll look at amending the patch to do this. (This patch was originally written for a version of libvirt where this macro did not yet exist!)
I can do that before pushing if you are OK with it, I'll keep your S-o-b.
Thanks, Mike
Attachment:
signature.asc
Description: PGP signature