On Tue, Feb 28, 2023 at 09:49:26AM -0500, Laine Stump wrote: > + * QEMU: properly report passt startup errors > + > + Due to how the child passt process was started, the initial > + support for passt (added in 9.0.0) would not see errors > + encountered during startup, so libvirt would continue to setup and > + start the guest; this led to a running guest with no network > + connectivity. This issue has be corrected. > + > + (NB: it is still necessary to disable SELinux to start passt.) This is also true for AppArmor, so I would mention both. Also, please make sure that there still are *two* empty lines between the section for v9.1.0 and the one for v9.0.0. The current version of the patch drops one of them. With the tweaks mentioned above, plus the stuff already pointed out by Peter, Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> -- Andrea Bolognani / Red Hat / Virtualization
