On Mon, Feb 20, 2023 at 02:33:55PM +0100, Erik Skultety wrote: > On Mon, Feb 20, 2023 at 03:02:42AM -0800, Andrea Bolognani wrote: > > On Mon, Feb 20, 2023 at 11:40:34AM +0100, Erik Skultety wrote: > > > On Mon, Feb 20, 2023 at 11:21:46AM +0100, Andrea Bolognani wrote: > > > > +sc_prohibit_python_without_env: > > > > + @prohibit='#!/usr/.*/py''thon' \ > > > > > > Shouldn't this be just '#!/usr/.*/python' ? > > > > Yes, but then the syntax-check rule would flag this very line :) > > > > We could do the "exempt from syntax-check" dance, but that feels > > unnecessarily complicated in this scenario. sc_copyright_usage > > already uses a similar trick to prevent the regex to match itself. > > Reviewed-by: Erik Skultety <eskultet@redhat> Missing the .com here, you might have a misconfiguration somewhere. Anyway, thanks for the review! Can you please ACK the first patch in the series too? I can't push this one without it. -- Andrea Bolognani / Red Hat / Virtualization
