On 04/14/2010 10:02 AM, Jim Meyering wrote: > From: Jim Meyering <meyering@xxxxxxxxxx> > > * src/util/util.c (virGetHostnameLocalhost): Add an sa_assert > to tell clang it's ok to dereference "info" after a non-failing > getaddrinfo call. > --- > src/util/util.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/src/util/util.c b/src/util/util.c > index 405c5f3..268944d 100644 > --- a/src/util/util.c > +++ b/src/util/util.c > @@ -2394,6 +2394,9 @@ char *virGetHostnameLocalhost(int allow_localhost) > return NULL; > } > > + /* Tell static analyzers about getaddrinfo semantics. */ > + sa_assert (info); > + ACK if 1/7 goes through, and thanks for the comment explaining why. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list