On 2/9/23 23:09, Praveen K Paladugu wrote: > virDomainDefAddConsoleCompat in post parsing step appends a stub console > of type VIR_DOMAIN_CHR_TYPE_NULL to ch VMs' Domain XML. Cloud-hypervisor's > deviceValidateCallback (chValidateDomainDeviceDef) checks that the type of > stub console is not of type VIR_DOMAIN_CHR_TYPE_PTY and throws an error. > > This commit introduces NO_STUB_CONSOLE feature check to Domain features and > uses it to skip adding stub console to ch VMs. > > Signed-off-by: Praveen K Paladugu <prapal@xxxxxxxxxxxxxxxxxxx> > --- > src/ch/ch_domain.c | 1 + > src/conf/domain_conf.c | 7 ++++--- > src/conf/domain_conf.h | 1 + > 3 files changed, 6 insertions(+), 3 deletions(-) Yes, I think we can finally break this backwards compatibility at least for this new driver. Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> and pushed. Michal
