On Wed, Feb 08, 2023 at 01:05:59PM +0100, Peter Krempa wrote:
> On Wed, Feb 08, 2023 at 12:49:01 +0100, Kristina Hanicova wrote:
> > +++ b/src/qemu/qemu_command.c
> > @@ -9557,6 +9557,25 @@ qemuBuildPanicCommandLine(virCommand *cmd,
> > break;
> > }
> >
> > + case VIR_DOMAIN_PANIC_MODEL_PVPANIC: {
> > + g_autoptr(virJSONValue) props = NULL;
> > +
> > + if (virJSONValueObjectAdd(&props,
> > + "s:driver", "pvpanic-pci",
> > + NULL) < 0)
> > + return -1;
> > +
> > + if (def->panics[i]->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) {
>
> This check doesn't make much sense ...
I imagine it was lifted from the ISA variant, handled just above,
where it's necessary because not specifying an address is somehow
considered a valid configuration.
I agree with you that it's not needed for pvpanic-pci.
--
Andrea Bolognani / Red Hat / Virtualization
