Re: [PATCH 1/1] Fix a trivial flake8 warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 08, 2023 at 09:58:29PM +0800, jshen28 wrote:
Remove an unused '_' in file


What flake warning are you trying to fix, could you elaborate?  When I
run flake8 on that file I only get:

tools/virt-qemu-qmp-proxy:233:80: E501 line too long (86 > 79 characters)

I have flake8-6.0.0:

6.0.0 (mccabe: 0.7.0, pycodestyle: 2.10.0, pyflakes: 3.0.1) CPython 3.10.10 on Linux

Signed-off-by: jshen28 <yshxxsjt715@xxxxxxx>
---
tools/virt-qemu-qmp-proxy | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virt-qemu-qmp-proxy b/tools/virt-qemu-qmp-proxy
index dfbaa1ff0c..2d9dd6495d 100755
--- a/tools/virt-qemu-qmp-proxy
+++ b/tools/virt-qemu-qmp-proxy
@@ -335,7 +335,7 @@ def main():
    sock.bind(args.sockpath)
    sock.listen(1)

-    _ = QMPProxy(conn, dom, sock, args.verbose)
+    QMPProxy(conn, dom, sock, args.verbose)


I don't think you can do that because the object could be garbage
collected, but I'm not sure how much havoc would that cause...

    while True:
        libvirt.virEventRunDefaultImpl()
--
2.17.1

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux