Re: [PATCH 07/10] virt-ssh-helper: Accept ?socket= in connection URI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 06, 2023 at 10:16:55 +0100, Michal Privoznik wrote:
> Similarly to the previous commit, let's accept "socket" parameter
> in the connection URI. This change will allow us to use
> virt-ssh-helper instead of 'nc' in all cases (done in one of
> future commits).
> 
> Please note, when the parameter is used it effectively disables
> automatic daemon spawning and an error is reported. But this is
> intentional - so that the helper behaves just like regular
> virConnectOpen() with different transport than ssh, e.g. unix.
> 
> But this 'change' is acceptable - there's no way for users to
> make our remote code pass the argument to virt-ssh-helper, yet.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/remote/remote_ssh_helper.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux