Re: [libvirt PATCH v2 0/8] Extract the integration job commands to a shell script

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 27, 2023 at 10:26:48AM +0100, Erik Skultety wrote:
> Using shell scripts rather than inlining shell commands to YAML feels more
> natural, more readable, and will keep all different variations of execution
> consistent. Essentially the only disadvantage is that we won't see each command
> listed one-by-one in gitlab's log output (unless we set -x that is), but given
> that shell would complain if something was wrong with the script, it's fairly
> easy to identify the problem.
> 
> Here's a test pipeline after the change:
> https://gitlab.com/eskultety/libvirt/-/pipelines/759277200
> 
> Since v1:
> - 3/7 - reworded commit message as requested
> - 4/7 was dropped
> - point the SCRATCH_DIR to /var/tmp instead of /tmp to not be limited by the
> size of ramdisk mounted in there

Ping.




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux