On 04/14/2010 02:46 AM, Jim Meyering wrote:
> From: Jim Meyering <meyering@xxxxxxxxxx>
>
> * src/storage/storage_backend_fs.c (virStorageBackendFileSystemMount):
> Use virAsprintf only when needed. In this case, strdup works fine.
> ---
> src/storage/storage_backend_fs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c
> index 0b81c6c..c96c4f3 100644
> --- a/src/storage/storage_backend_fs.c
> +++ b/src/storage/storage_backend_fs.c
> @@ -376,7 +376,7 @@ virStorageBackendFileSystemMount(virStoragePoolObjPtr pool) {
>
> if (pool->def->type == VIR_STORAGE_POOL_NETFS) {
> if (pool->def->source.format == VIR_STORAGE_POOL_NETFS_GLUSTERFS) {
> - if (virAsprintf(&options, "direct-io-mode=1") == -1) {
> + if ((options = strdup("direct-io-mode=1")) == NULL) {
ACK - much lighter-weight.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list