On Thu, Jan 26, 2023 at 01:41:24PM +0100, Michal Privoznik wrote:
Recently, in v9.0.0-7-gb2034bb04c we've dropped initialization of @args variable. The reasoning was that eventually, all members of the variable will be set. Well, this is not correct. For instance, in remoteConnectGetAllDomainStats() the args.doms.doms_val pointer is set iff @ndoms != 0. However, regardless of that, the pointer is then passed to VIR_FREE(). Worse, the whole args is passed to xdr_remote_connect_get_all_domain_stats_args() which then calls xdr_array, which tests the (uninitialized) pointer against NULL. This effectively reverts b2034bb04c61c75ddbfbed46879d641b6f8ca8dc. Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
