On 1/17/23 02:46, zhenwei pi wrote: > Changes in this commit: > - docs: formatdomaincaps.rst > - conf: crypto related domain caps > - qemu: crypto related > - tests: crypto related test > > Signed-off-by: zhenwei pi <pizhenwei@xxxxxxxxxxxxx> > --- > 90 files changed, 774 insertions(+) > > diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c > index 56cad891cc..d2b8ee01f6 100644 > --- a/src/qemu/qemu_capabilities.c > +++ b/src/qemu/qemu_capabilities.c > @@ -684,6 +684,9 @@ VIR_ENUM_IMPL(virQEMUCaps, > /* 440 */ > "machine-hpet", /* QEMU_CAPS_MACHINE_HPET */ > "netdev.stream", /* QEMU_CAPS_NETDEV_STREAM */ > + "virtio-crypto", /* QEMU_CAPS_DEVICE_VIRTIO_CRYPTO */ > + "cryptodev-backend-builtin", /* QEMU_CAPS_OBJECT_CRYPTO_BUILTIN */ Isn't this always available? Looking into qemu.git/backends/meson.build it can't be compiled out, and nothing inside the file is conditinally compiled either. > + "cryptodev-backend-lkcf", /* QEMU_CAPS_OBJECT_CRYPTO_LKCF */ > ); Also, this is the best time to extend the validation function introduced in the previous patch (qemuValidateDomainDeviceDefCrypto()). We want to check whether QEMU supports selected combination of values (e.g. backend). In my suggested patch you'll find couple of checks that might look needless today, but if we ever introduce new model or type they are already there and can save us. Michal
