On 1/13/23 10:05, Andrea Bolognani wrote:
On Wed, Jan 11, 2023 at 03:05:57PM -0700, Jim Fehlig wrote:
Change the dependency to a 'Wants' to avoid a pacakge
*package
+++ b/libvirt.spec.in
@@ -775,7 +776,8 @@ QEMU
%if %{with_lxc}
%package daemon-driver-lxc
Summary: LXC driver plugin for the libvirtd daemon
-Requires: libvirt-daemon = %{version}-%{release}
+Requires: libvirt-daemon-common = %{version}-%{release}
+Requires: libvirt-daemon-log = %{version}-%{release}
Does the lxc driver actually use virtlogd by default in the same way
the qemu driver does?
AFAICT, no, it does not. I don't recall what got me to thinking it was needed...
If so, we need a Requires=virtlogd.socket in
the corresponding unit file, and also libvirt-daemon-lxc needs to
Require: libvirt-daemon-log by the end of the series.
+++ b/src/libxl/virtxend.service.in
@@ -1,10 +1,10 @@
[Unit]
Description=Virtualization xen daemon
Conflicts=libvirtd.service
-Requires=virtlockd.socket
Requires=virtxend.socket
Requires=virtxend-ro.socket
Requires=virtxend-admin.socket
+Wants=virtlockd.socket
[...]
+++ b/src/qemu/virtqemud.service.in
@@ -2,10 +2,10 @@
Description=Virtualization qemu daemon
Conflicts=libvirtd.service
Requires=virtlogd.socket
-Requires=virtlockd.socket
Requires=virtqemud.socket
Requires=virtqemud-ro.socket
Requires=virtqemud-admin.socket
+Wants=virtlockd.socket
I would make these changes in a separate preparatory patch, and
modify libvirtd.service in the same way at that time.
Ok, will do in V9.
Regards,
Jim
