On Sun, Jan 08, 2023 at 11:11:07PM -0500, Laine Stump wrote: > Initial support for network devices using passt (https://passt.top) > for the backend connection will require: > > * new attributes of the <backend> subelement: > * "type" that can have the value "passt" (to differentiate from > slirp, because both slirp and passt will use <interface > type='user'>) > * "logFile" (a path to a file that passt should use for its logging) > * "upstream" (a netdev name, e.g. "eth0"). IMHO this attribute is inappropriate for <backend>.... > * a new subelement <portForward> (described in more detail later) > > Signed-off-by: Laine Stump <laine@xxxxxxxxxx> > --- > src/conf/schemas/domaincommon.rng | 65 +++++++++++++++++++++++ > tests/qemuxml2argvdata/net-user-passt.xml | 57 ++++++++++++++++++++ > 2 files changed, 122 insertions(+) > create mode 100644 tests/qemuxml2argvdata/net-user-passt.xml > > diff --git a/tests/qemuxml2argvdata/net-user-passt.xml b/tests/qemuxml2argvdata/net-user-passt.xml > new file mode 100644 > index 0000000000..b82eebd089 > --- /dev/null > +++ b/tests/qemuxml2argvdata/net-user-passt.xml > @@ -0,0 +1,57 @@ > +<domain type='qemu'> > + <name>QEMUGuest1</name> > + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> > + <memory unit='KiB'>219136</memory> > + <currentMemory unit='KiB'>219136</currentMemory> > + <vcpu placement='static'>1</vcpu> > + <os> > + <type arch='x86_64' machine='pc'>hvm</type> > + <boot dev='hd'/> > + </os> > + <clock offset='utc'/> > + <on_poweroff>destroy</on_poweroff> > + <on_reboot>restart</on_reboot> > + <on_crash>destroy</on_crash> > + <devices> > + <emulator>/usr/bin/qemu-system-x86_64</emulator> > + <disk type='block' device='disk'> > + <driver name='qemu' type='raw'/> > + <source dev='/dev/HostVG/QEMUGuest1'/> > + <target dev='hda' bus='ide'/> > + <address type='drive' controller='0' bus='0' target='0' unit='0'/> > + </disk> > + <controller type='usb' index='0' model='none'/> > + <controller type='ide' index='0'> > + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> > + </controller> > + <controller type='pci' index='0' model='pci-root'/> > + <interface type='user'> > + <mac address='00:11:22:33:44:55'/> > + <ip address='172.17.2.0' family='ipv4' prefix='24'/> > + <ip address='2001:db8:ac10:fd01::feed' family='ipv6'/> > + <portForward proto='tcp' address='2001:db8:ac10:fd01::1:10'> > + <range start='22' to='2022'/> > + <range start='1000' end='1050'/> > + <range start='1020' exclude='yes'/> > + <range start='1030' end='1040' exclude='yes'/> > + </portForward> > + <portForward proto='udp' address='1.2.3.4' dev='eth0'> > + <range start='5000' end='5020' to='6000'/> > + <range start='5010' end='5015' exclude='yes'/> > + </portForward> > + <portForward proto='tcp'> > + <range start='80'/> > + </portForward> > + <portForward proto='tcp'> > + <range start='443' to='344'/> > + </portForward> > + <model type='rtl8139'/> > + <backend type='passt' logFile='/var/log/loglaw.blog' upstream='eth42'/> I don't think that 'upstream' is really describing a property of the backend. This is expressing a traffic routing restriction for the 'user' networking type. IMHO it should probably be using the existing <source dev="xxxx"/> element, that is currently used by the 'direct' networking type. Can we see about fixing this before release. > + <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> > + </interface> > + <input type='mouse' bus='ps2'/> > + <input type='keyboard' bus='ps2'/> > + <audio id='1' type='none'/> > + <memballoon model='none'/> > + </devices> > +</domain> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
