On Mon, Jan 09, 2023 at 02:09:24PM +0100, Peter Krempa wrote: > Some compilers aren't happy when an automatically freed variable is used > just to free something (thus it's only assigned in the code): > > When compiling qemuSnapshotDelete after recent commits they complain: > > ../src/qemu/qemu_snapshot.c:3153:61: error: variable 'delData' set but not used [-Werror,-Wunused-but-set-variable] > g_autoslist(qemuSnapshotDeleteExternalData) delData = NULL; > ^ > > To work around the issue we can restructure the code which also has the > following semantic implications: > - since qemuSnapshotDeleteExternalPrepare does validation we error out > sooner than attempting to start the VM > > - we read the temporary variable at least in one code path > > Fixes: 4a4d89a9252 > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > --- > src/qemu/qemu_snapshot.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
