On Mon, Apr 12, 2010 at 11:23:54PM +0200, Daniel Berteaud wrote:
> Hi.
>
> I've downloaded libvirt 0.8.0, and tried to re-build a rpm (on CentOS
> 5.4 x86_64), and found that there's a small bug in the spec file.
>
> Line 608:
>
> rm -rf $RPM_BUILD_ROOT%{_sysconfdir}/logrotate.d/libvirtd.qemu
>
> Should be:
>
> rm -rf $RPM_BUILD_ROOT%{_sysconfdir}/logrotate.d/libvirtd.lxc
>
>
> Without this modification, the package fails to build when LXC is
> disabled or not abailable.
Yep, that makes sense.
> (Sorry, I really don't know GIT, and so, cannot provide a clean patch)
It isn't as hard as it might seem:-) For general reference, if anyone
else is wondering about a easy way to make some quick fixes for libvirt
in GIT, this is a 30 second overview avoiding all the hard bits of GIT...
0. Set your name & email in GIT if not already done
# git config --global user.name "Daniel Berrange"
# git config --global user.email "berrange@xxxxxxxxxx"
1. Get a local checkout
# git checkout git://libvirt.org/libvirt.git
2. Create a branch 'misc-fixes' (or whatever name you like) where
you'll make your change(s)
# cd libvirt
# git checkout -b misc-fixes
3. Make your changes...
emacs blah.c foo.c
4. Commit the changed files
git add blah.c foo.c
git commit
5. Repeat steps 3 & 4 several times if desired to make a series of changes
6. Send us the change(s)...
a) Either format all changes on the branch as patches
git format-patch master..misc-fixes
...manually email the patch files created...
b) Or email the branch directly from git
git send-email -c libvir-list@xxxxxxxxxx master..misc-fixes
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list