Re: [PATCH 0/7] Support crypto device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/4/23 04:29, zhenwei pi wrote:
> Hi,
> 
> This series supports crypto device, also add support for QEMU.
> The basic xml schema looks like:
>       <crypto model='virtio' type='qemu'>
>         <backend model='builtin' queues='1'/>
>         <address type='pci' domain='0x0000' bus='0x00' slot='0x0a' function='0x0'/>
>       </crypto>
> 
>       <crypto model='virtio' type='qemu'>
>         <backend model='lkcf'/>
>         <address type='pci' domain='0x0000' bus='0x00' slot='0x0b' function='0x0'/>
>       </crypto>
> 
> Each patch has been tested by 'ninja -C build test', and launch a QEMU
> with crypto devices, it works fine.
> 

I've got couple of suggestions. For patch 2/7 I've created a 'fixup'
commit and uploaded the whole branch onto my gitlab:

https://gitlab.com/MichalPrivoznik/libvirt/-/commits/crypto_review

Please check it out and consider squashing it in. For other suggestions
I did not create such commit.

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux