On Thu, Dec 22, 2022 at 11:03:36AM -0700, Jim Fehlig wrote:
> The new name "libvirt-daemon-plugin-sanlock" provides consistency with the
> newly introduced "libvirt-daemon-plugin-lockd" subpackage.
>
> It's also a good opportunity to taking ownership of
> %{_libdir}/libvirt/lock-driver/, removing the need for a dependency on the
> libvirt-daemon package.
>
> Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx>
> ---
> docs/kbase/rpm-deployment.rst | 12 ++++++------
> libvirt.spec.in | 10 ++++++----
> 2 files changed, 12 insertions(+), 10 deletions(-)
>
[...]
>
> @@ -1822,7 +1824,6 @@ exit 0
> %dir %attr(0711, root, root) %{_localstatedir}/cache/libvirt/
> %dir %attr(0755, root, root) %{_libdir}/libvirt/
> %dir %attr(0755, root, root) %{_libdir}/libvirt/connection-driver/
> -%dir %attr(0755, root, root) %{_libdir}/libvirt/lock-driver/
> %dir %attr(0755, root, root) %{_libdir}/libvirt/storage-backend/
> %dir %attr(0755, root, root) %{_libdir}/libvirt/storage-file/
> %{_datadir}/augeas/lenses/libvirtd.aug
> @@ -2162,13 +2163,14 @@ exit 0
> %endif
>
> %if %{with_sanlock}
> -%files lock-sanlock
> +%files daemon-plugin-sanlock
> %if %{with_qemu}
> %config(noreplace) %{_sysconfdir}/libvirt/qemu-sanlock.conf
> %endif
> %if %{with_libxl}
> %config(noreplace) %{_sysconfdir}/libvirt/libxl-sanlock.conf
> %endif
> +%dir %attr(0755, root, root) %{_libdir}/libvirt/lock-driver/
Oh, this is where you should have dropped the dependency on
libvirt-daemon, as hinted in the commit message.
With that fixed,
Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
--
Andrea Bolognani / Red Hat / Virtualization
