On Fri, Dec 23, 2022 at 04:42:08AM -0500, Andrea Bolognani wrote:
> On Thu, Dec 22, 2022 at 11:03:41AM -0700, Jim Fehlig wrote:
> > %package daemon-qemu
> > Summary: Server side daemon & driver required to run QEMU guests
> >
> > + %if %{with_modular_daemons}
> > +Requires: libvirt-daemon-common = %{version}-%{release}
> > +Requires: libvirt-daemon-log = %{version}-%{release}
> > +Requires: libvirt-daemon-lock = %{version}-%{release}
> > +Requires: libvirt-daemon-plugin-lockd = %{version}-%{release}
> > + %else
> > Requires: libvirt-daemon = %{version}-%{release}
> > + %endif
> >
> > %package daemon-kvm
> > Summary: Server side daemon & driver required to run KVM guests
> >
> > + %if %{with_modular_daemons}
> > +Requires: libvirt-daemon-common = %{version}-%{release}
> > +Requires: libvirt-daemon-log = %{version}-%{release}
> > +Requires: libvirt-daemon-lock = %{version}-%{release}
> > +Requires: libvirt-daemon-plugin-lockd = %{version}-%{release}
> > + %else
> > Requires: libvirt-daemon = %{version}-%{release}
> > + %endif
> >
> > %package daemon-lxc
> > Summary: Server side daemon & driver required to run LXC guests
> >
> > + %if %{with_modular_daemons}
> > +Requires: libvirt-daemon-common = %{version}-%{release}
> > + %else
> > Requires: libvirt-daemon = %{version}-%{release}
> > + %endif
> >
> > %package daemon-xen
> > Summary: Server side daemon & driver required to run XEN guests
> > + %if %{with_modular_daemons}
> > +Requires: libvirt-daemon-common = %{version}-%{release}
> > +Requires: libvirt-daemon-lock = %{version}-%{release}
> > +Requires: libvirt-daemon-plugin-lockd = %{version}-%{release}
> > + %else
> > Requires: libvirt-daemon = %{version}-%{release}
> > + %endif
> >
> > %package daemon-vbox
> > Summary: Server side daemon & driver required to run VirtualBox guests
> > + %if %{with_modular_daemons}
> > +Requires: libvirt-daemon-common = %{version}-%{release}
> > + %else
> > Requires: libvirt-daemon = %{version}-%{release}
> > + %endif
>
> So the xen driver doesn't use virtlogd, and the lxc and vbox drivers
> don't use locking either? It's nice that we're making some of the
> deployments leaner by default :)
>
> I wonder if we could leave the locking part out for *all* of the
> above, with the rationale that it's something that you have to
> explicitly enable at the configuration file level anyway. But I guess
> that wouldn't work too well when it comes to updates. Maybe after
> Enough Time™ has passed?
Actually, since after your changes the libvirt-daemon package still
depends on libvirt-daemon-log, libvirt-daemon-lock and all the new
packages that contain files that were originally in that package, I
think the upgrade scenarios are taken care of by that and we could
trim down the libvirt-daemon-{qemu,kvm,xen} packages like I suggested
above. Dan, what do you think?
--
Andrea Bolognani / Red Hat / Virtualization
