On Tue, Dec 13, 2022 at 05:30:57PM -0700, Jim Fehlig wrote:
> Introduce the libvirt-daemon-plugin-lockd subpackage to provide the
> client-side lockd plugin for virtlockd.
>
> The sanlock plugin also needs the directory %{_libdir}/libvirt/lock-driver,
> which it currently gets via the libvirt-daemon dependency. Duplicate the
> directory in the %files section of the sanlock plugin, allowing the
> libvirt-daemon dependency to be dropped.
I think it would be slightly neater if you introduced the new package
with a dependency on libvirt-daemon and left the existing dependency
in the sanlock package alone. Then, after introducing the
libvirt-daemon-common package, you could replace those dependencies
with the more lightweight ones at the same time as you're doing so
for all other packages.
> +%package daemon-plugin-lockd
> +Summary: lockd client plugin for virtlockd
> +Requires: libvirt-libs = %{version}-%{release}
I think you should have a dependency on libvirt-daemon-lock here,
since the lockd.so plugin requires virtlockd in order to work.
--
Andrea Bolognani / Red Hat / Virtualization
