On Thu, Dec 08, 2022 at 14:30:40 +0100, Pavel Hrdina wrote: > This will allow to use it while having async domain job active which we > will use when deleting external snapshots. At the same time we will need > to have the block job started as synchronous. > > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> > --- > src/qemu/qemu_block.c | 7 ++++++- > src/qemu/qemu_block.h | 1 + > src/qemu/qemu_driver.c | 3 ++- > 3 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c > index 721145fa42..999e43c630 100644 > --- a/src/qemu/qemu_block.c > +++ b/src/qemu/qemu_block.c > @@ -3205,6 +3205,7 @@ qemuBlockCommit(virDomainObj *vm, > virStorageSource *topSource, > virStorageSource *top_parent, > unsigned long bandwidth, > + virDomainAsyncJob asyncJob, > unsigned int flags) Please add a function comment which describes parameters and mention in it that setting asyncJob makes the block job behave synchronous in the comment. It's quite an important semantic fact. Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
