Re: [libvirt PATCH v3 02/18] qemu: Add functions for determining nbdkit availability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/12/22 2:41 AM, Peter Krempa wrote:
On Fri, Dec 09, 2022 at 12:25:11 -0500, Laine Stump wrote:
On 12/7/22 6:34 AM, Peter Krempa wrote:
On Thu, Oct 20, 2022 at 16:58:53 -0500, Jonathon Jongsma wrote:

+ *
+ * Copyright (C) 2021 Red Hat, Inc.

Also consider updating the year.

For a long time I always updated the year in copyright notices when I
changed a file (even still have an emacs extension that asks me if I want to
do it the first time I save a file after loading it), but I recall there was
some sentiment against doing that, so I stopped updating it. Did I
misunderstand the discussion then, and I've been neglecting my duties? Was
it that we shouldn't update the copyright if it was only trivial changes,
otherwise we should?

I still think it's pointless to do when simpy editing an existing file.
This is a new file though.

Ah, I didn't even notice that detail :-)


In fact plenty new files don't actually even add an explicit copyright
statement.

Yeah, I just noticed a couple days ago that qemu_slirp.h has the copyright blurb, but no explicit "Copyright" or date. I wondered if maybe it was because it was just a simple .h file, and that too was something I missed the memo on...





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux