Re: [libvirt PATCH v3 10/18] tests: add ability to test various nbdkit capabilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 20, 2022 at 16:59:01 -0500, Jonathon Jongsma wrote:
> Add new DO_TEST_CAPS_LATEST_NBDKIT macro to test xml2argv for various
> nbdkit capability scenarios.
> 
> Signed-off-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>
> ---
>  src/qemu/qemu_nbdkit.c   | 20 +++++++++++++++++---
>  tests/qemuxml2argvtest.c | 11 +++++++++++
>  tests/testutilsqemu.c    | 27 +++++++++++++++++++++++++++
>  tests/testutilsqemu.h    |  5 +++++
>  4 files changed, 60 insertions(+), 3 deletions(-)


> diff --git a/tests/testutilsqemu.h b/tests/testutilsqemu.h
> index 943958d02a..618837559c 100644
> --- a/tests/testutilsqemu.h
> +++ b/tests/testutilsqemu.h
> @@ -28,6 +28,7 @@
>  # define TEST_TPM_ENV_VAR "VIR_TEST_MOCK_FAKE_TPM_VERSION"
>  # define TPM_VER_1_2 "1.2"
>  # define TPM_VER_2_0 "2.0"
> +# define TEST_NBDKIT_PATH "/usr/bin/nbdkit"

Preferrably select some clearly fake path here so that if something
tries to access it it fails.

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux