On Thu, Dec 08, 2022 at 05:09:39PM +0000, Daniel P. Berrangé wrote: > On Thu, Dec 08, 2022 at 06:06:23PM +0100, Andrea Bolognani wrote: > > The script had an incorrect interpreter line until commit > > f6a19d7264bb, so the flake8 check would not realize it needed > > to pick it up and these issues, some of which were present it > > the very first version that was committed, were not being > > reported. > > Hmm, if flake8 is going to be restricted to /usr/bin/env python, > then we ought to have a syntax check to forbid /usr/bin/python*, > to prevent missing the flake8 check. That would certainly be good to have. Regardless of the flake8 check, you simply don't want to hardcode a path to the Python interpreter there, as it will prevent the script from working on FreeBSD and macOS at the very least. -- Andrea Bolognani / Red Hat / Virtualization
