Re: [libvirt PATCH] qemu: Pass vm to qemuMigrationCookieParse if it exists

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/30/22 15:24, Jiri Denemark wrote:
> The vm object is used inside qemuMigrationCookieParse based on the flags
> passed to qemuMigrationCookieParse and the content of the cookie. The
> callers should not just blindly guess and pass NULL if they
> (incorrectly) think the vm object is not needed. We should always pass
> the vm object unless it does not exist yet.
> 
> This fixes a bug when statistics of a completed migration reported
> "Unknown" operation instead of "Incoming migration" on the destination
> host.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=2137298
> 
> Fixes: v8.7.0-79-g0150f7a8c1
> Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> ---
>  src/qemu/qemu_migration.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux