On a Tuesday in 2022, Michal Privoznik wrote:
Inside of qemuTPMEmulatorBuildCommand() there are two calls to qemuTPMSetupEncryption() which simply ignore returned error. This is suboptimal because then we rely on swtpm binary reporting a generic error (something among invalid arguments) while an error reported by qemuTPMSetupEncryption() is more specific.
It seems like qemuTPMSetupEncryption does not report an error in all cases, specifically virCommandSetSendBuffer only sets an errno. So in that case, "no error message" would be a downgrade from "generic error message". Jano
Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> --- src/qemu/qemu_tpm.c | 5 +++++ 1 file changed, 5 insertions(+)
Attachment:
signature.asc
Description: PGP signature
