On 11/9/22 09:15, Daniel P. Berrangé wrote: > On Tue, Nov 08, 2022 at 08:35:31PM +0100, Roman Bogorodskiy wrote: >> clang 14.0.5 complains: >> >> ../src/bhyve/bhyve_device.c:42:29: error: mixing declarations and code >> is incompatible with standards before C99 > > Err, we set std=gnu99 so it shouldn't be complaining about that. But we also enable -Wdeclaration-after-statement which checks for the same thing. I wonder how could gcc not identify these. > >> [-Werror,-Wdeclaration-after-statement] >> virDomainPCIAddressSet *addrs = opaque; >> ^ >> 1 error generated. >> >> And a few similar errors in some other places, mainly bhyve related. >> Apply a trivial fix to resolve that. > > > None the less I don't like the mixing of decls/code, as it has very > confusing/misleading semantics when combined with goto's that jump > over a decl Yep. Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Michal
