2010/4/7 Daniel Veillard <veillard@xxxxxxxxxx>: > On Tue, Apr 06, 2010 at 11:38:00PM +0200, Matthias Bolte wrote: >> Extend tests to cover all SCSI controller types and document the >> new type. >> >> The lsisas1068 SCSI controller type was added in ESX 4.0. The VMX >> parser reports an error when this controller type is present. This >> makes virsh dumpxml fail for every domain that uses this controller >> type. >> >> This patch fixes this and adds lsisas1068 to the list of accepted >> SCSI controller types. >> >> Reported by Jonathan Kelley. >> --- >> >> This is a repost of this patch [1]. >> >> DanPB pointed out that the ESX driver is currently abusing the <driver> >> element to expose the SCSI controller type. >> >> Now we have the <controller> element to explicitly model stuff like >> SCSI controllers in the domain XML config. The ESX driver doesn't >> support this yet. Also there is currently no way to express the SCSI >> controller type in the <controller> element. Something like the model >> attribute for NICs need to be added here too. >> >> So I'd like to push this patch now in order to have the immediate >> problem of failing virsh dumpxml fixed in libvirt 0.8.0. I already got >> asked offlist when this problem will be fixed. >> >> [1] https://www.redhat.com/archives/libvir-list/2010-March/msg00548.html > > Well the abuse is already in place for lsilogic and buslogic, > so okay for pushing this now, but please let's fix the XML format > problem after the release, Yes, that's the plan. > > ACK, > > Daniel > Thanks, pushed. Matthias -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list