On Thu, Sep 22, 2022 at 04:35:51PM +0200, Martin Kletzander wrote:
On Tue, Sep 13, 2022 at 12:30:31PM -0700, Lin Yang wrote:AMX was introduced in QEMU commit 1f16764f7d4515bfd5e4ae0aae814fa280a7d0c8 and following commits.Some of them not pushed yet I believe: https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg01936.html Otherwise the patch looks good (I'm not sure what's the planned usage of the python script, but this patch just adds features that'd be missing in the future, so I think it's fine). Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
I still can't see the other commits in QEMU mentioning the other features, but I can't see how those missing could cause an issue, so in the end I removed the "and following commits". We also require a Signed-off-by for contributions as written in our contribution guidelines: https://libvirt.org/hacking.html If you say I can add one for you with the current e-mail address there's no need to resend this patch and I can add it before pushing. Thanks for the patch.
Attachment:
signature.asc
Description: PGP signature
