On Mon, Oct 31, 2022 at 09:38:13 +0000, Daniel P. Berrangé wrote: > On Fri, Oct 28, 2022 at 05:06:34PM +0200, Tim Wiederhake wrote: > > Signed-off-by: Tim Wiederhake <twiederh@xxxxxxxxxx> > > Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx> > > --- > > src/cpu_map/x86_features.xml | 55 +++++++++++++++++++++++++----------- > > 1 file changed, 38 insertions(+), 17 deletions(-) > > > > diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml > > index 4cf3ff0804..90d0f43fc6 100644 > > --- a/src/cpu_map/x86_features.xml > > +++ b/src/cpu_map/x86_features.xml > > @@ -98,10 +98,12 @@ > > </feature> > > > > <!-- standard features, ECX --> > > - <feature name='pni'> <!-- sse3 --> > > + <feature name='pni'> > > + <alias name='sse3'/> > > IMHO, we should distinguish this as internal data via a NS to > re-inforce to our future selves that its only used when syncing > data from QEMU. > > <qemu:alias nmame="sse3"/> > > And add xmlns:qemu="https://libvirt.org/cpufeature/qemu/1.0"; on > the top level. Well, the existing alternative names in comments were not just different QEMU spellings. Some of them were names used by the kernel. But I don't really mind either way. Jirka
