Re: [libvirt] qemuDomainSnapshotLoad leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/07/2010 02:26 PM, Jim Meyering wrote:
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index d1684b8..f5cf1f1 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -1354,7 +1354,6 @@ static void qemuDomainSnapshotLoad(void *payload,
>      char *xmlStr;
>      int ret;
>      char *fullpath;
> -    virDomainSnapshotObjPtr snap = NULL;
>      virDomainSnapshotDefPtr def = NULL;
>      char ebuf[1024];
> 
> @@ -1406,7 +1405,7 @@ static void qemuDomainSnapshotLoad(void *payload,
>              continue;
>          }
> 
> -        snap = virDomainSnapshotAssignDef(&vm->snapshots, def);
> +        virDomainSnapshotAssignDef(&vm->snapshots, def);
> 
>          VIR_FREE(xmlStr);
>      }

Yeah, this looks perfectly good.

ACK

-- 
Chris Lalancette

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]