On 10/4/22 17:33, Stefan Berger wrote: > > > On 10/4/22 10:39, Michal Prívozník wrote: > >>> >> >> Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> >> >> and pushed. > > Thanks. > > Regarding shared storage and migration. Should shared storage support be > implemented using an XML attribute or through a new migration option > (--tpm-shared-storage)? The previously proposed implementation used an > XML attribute that may be easier to accommodate by higher layers that > then don't need to support a new migration option just a slighly > different XML but that may not be how it should be done... Yeah, I've been meaning to look into that discussion and patches. I don't know if it was suggested, but maybe a flag to migration APIs? We do storage migration that way. Or do we need to pass the flag to swtpm even way before migration is started (e.g. on domain startup)? Michal