On 04/06/2010 01:09 PM, Jim Meyering wrote:
IMHO, this qualifies as an "obvious" fix, but I'll wait for an ACK.
From 0c9eb193ccb0ad507c7dd6dbfe944bb9a0c8ff93 Mon Sep 17 00:00:00 2001
From: Jim Meyering<meyering@xxxxxxxxxx>
Date: Tue, 6 Apr 2010 19:07:14 +0200
Subject: [PATCH] virterror.c: avoid erroneous case "fall-through"
* src/util/virterror.c (virErrorMsg): Insert missing "break;"
---
src/util/virterror.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/util/virterror.c b/src/util/virterror.c
index d29f95b..96dd1e7 100644
--- a/src/util/virterror.c
+++ b/src/util/virterror.c
@@ -1,10 +1,10 @@
/*
* virterror.c: implements error handling and reporting code for libvirt
*
- * Copy: Copyright (C) 2006, 2008, 2009 Red Hat, Inc.
+ * Copy: Copyright (C) 2006, 2008-2010 Red Hat, Inc.
*
* See COPYING.LIB for the License of this software
*
* Author: Daniel Veillard<veillard@xxxxxxxxxx>
*/
@@ -1147,12 +1147,13 @@ virErrorMsg(virErrorNumber error, const char *info)
break;
case VIR_ERR_MIGRATE_PERSIST_FAILED:
if (info == NULL)
errmsg = _("Failed to make domain persistent after migration");
else
errmsg = _("Failed to make domain persistent after migration: %s");
+ break;
case VIR_ERR_HOOK_SCRIPT_FAILED:
if (info == NULL)
errmsg = _("Hook script execution failed");
else
errmsg = _("Hook script execution failed: %s");
break;
--
1.7.0.4.552.gc303
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
ACK
Dave
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list