On Mon, Sep 5, 2022 at 6:21 PM Ján Tomko <jtomko@xxxxxxxxxx> wrote:
On a Monday in 2022, Kristina Hanicova wrote:
>This patch removes virCHDomainObjBeginJob() and replaces it with
>call to the generalized virDomainObjBeginJob().
>
>Signed-off-by: Kristina Hanicova <khanicov@xxxxxxxxxx>
>---
> src/ch/ch_domain.c | 51 +---------------------------------------------
> src/ch/ch_domain.h | 4 ----
> src/ch/ch_driver.c | 20 +++++++++---------
> 3 files changed, 11 insertions(+), 64 deletions(-)
>
>diff --git a/src/ch/ch_domain.c b/src/ch/ch_domain.c
>index 9ddf9a8584..c592c6ffbb 100644
>--- a/src/ch/ch_domain.c
>+++ b/src/ch/ch_domain.c
>@@ -32,60 +32,11 @@
>
> VIR_LOG_INIT("ch.ch_domain");
>
>-/*
>- * obj must be locked before calling, virCHDriver must NOT be locked
>- *
>- * This must be called by anything that will change the VM state
>- * in any way
>- *
>- * Upon successful return, the object will have its ref count increased.
>- * Successful calls must be followed by EndJob eventually.
>- */
>-int
>-virCHDomainObjBeginJob(virDomainObj *obj, virDomainJob job)
>-{
>- unsigned long long now;
>- unsigned long long then;
>-
>- if (virTimeMillisNow(&now) < 0)
>- return -1;
>- then = now + CH_JOB_WAIT_TIME;
>-
This removes the last use of CH_JOB_WAIT_TIME. I can squash in the
removal of it before pushing.
Thank you for noticing, that would be great.
Kristina
