Re: [libvirt] [PATCH] nwfilter: RHEL 5 gcc fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Daniel Veillard <veillard@xxxxxxxxxx> wrote on 04/06/2010 04:16:35 AM:


> Please respond to veillard

>
> On Mon, Apr 05, 2010 at 05:23:41PM -0400, Stefan Berger wrote:
> > This patch fixes some compilation issues for the RHEL5 build. I am
> also removing the IPV6 constant where it appears in the wrong place.
> >
> > Seems like a new bad thing to rely on the compiler to tell about
> potentially uninitialized vars...
>
>   hum, why ?


it seems the newer gcc don't tell about uninitialized variables?
>
> > Signed-off-by; Stefan Berger <stefanb@xxxxxxxxxx>
> >
> > ---
> >  src/conf/nwfilter_conf.c |    7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
>
>   Patch looks fine to me,
>
>   ACK,


Pushed.
   Stefan

>
> Daniel
>
> --
> Daniel Veillard      | libxml Gnome XML XSLT toolkit  
http://xmlsoft.org/
> daniel@xxxxxxxxxxxx  | Rpmfind RPM search engine
http://rpmfind.net/
>
http://veillard.com/ | virtualization library  http://libvirt.org/
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]