Re: [PATCH] cpu_map: Introduce A64FX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 31, 2022 at 09:22:16 +0000, Liu Yiding wrote:
> Add A64FX as a supported cpu model.
> 
> Signed-off-by: Liu Yiding <liuyd.fnst@xxxxxxxxxxx>
> ---
>  src/cpu_map/arm_A64FX.xml   | 6 ++++++
>  src/cpu_map/arm_vendors.xml | 1 +
>  src/cpu_map/index.xml       | 3 +++
>  src/cpu_map/meson.build     | 1 +
>  4 files changed, 11 insertions(+)
>  create mode 100644 src/cpu_map/arm_A64FX.xml
> 
> diff --git a/src/cpu_map/arm_A64FX.xml b/src/cpu_map/arm_A64FX.xml
> new file mode 100644
> index 0000000000..db7b328cd1
> --- /dev/null
> +++ b/src/cpu_map/arm_A64FX.xml
> @@ -0,0 +1,6 @@
> +<cpus>
> +  <model name='a64fx'>

The model name is "a64fx" while the file name contains A64FX. We should
be consistent and use the same spelling for both.

> +    <vendor name='FUJITSU'/>
> +    <pvr value='0x001'/>
> +  </model>
> +</cpus>
> diff --git a/src/cpu_map/arm_vendors.xml b/src/cpu_map/arm_vendors.xml
> index 4465463b5b..b10c07815a 100644
> --- a/src/cpu_map/arm_vendors.xml
> +++ b/src/cpu_map/arm_vendors.xml
> @@ -3,6 +3,7 @@
>    <vendor name='Broadcom' value='0x42'/>
>    <vendor name='Cavium' value='0x43'/>
>    <vendor name='DigitalEquipment' value='0x44'/>
> +  <vendor name='FUJITSU' value='0x46'/>

You spell the vendor name as "Fujitsu" below in the cpu_map comment.
Which one is correct?

>    <vendor name='HiSilicon' value='0x48'/>
>    <vendor name='Infineon' value='0x49'/>
>    <vendor name='Freescale' value='0x4D'/>
> diff --git a/src/cpu_map/index.xml b/src/cpu_map/index.xml
> index 351c2ae4fa..44534f067a 100644
> --- a/src/cpu_map/index.xml
> +++ b/src/cpu_map/index.xml
> @@ -104,6 +104,9 @@
>      <!-- Cavium-based CPU models -->
>      <include filename='arm_ThunderX299xx.xml'/>
>  
> +    <!-- Fujitsu-based CPU models -->
> +    <include filename='arm_A64FX.xml'/>
> +
>      <!-- Hisilicon-based CPU models -->
>      <include filename='arm_Kunpeng-920.xml'/>
>  
> diff --git a/src/cpu_map/meson.build b/src/cpu_map/meson.build
> index 99815981b5..af7e5bc9f3 100644
> --- a/src/cpu_map/meson.build
> +++ b/src/cpu_map/meson.build
> @@ -1,4 +1,5 @@
>  cpumap_data = [
> +  'arm_A64FX.xml',
>    'arm_cortex-a53.xml',
>    'arm_cortex-a57.xml',
>    'arm_cortex-a72.xml',

Jirka




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux