On Tue, Aug 23, 2022 at 18:32:09 +0200, Pavel Hrdina wrote: The commit message will need some work ... > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> > --- > src/qemu/qemu_block.c | 6 ++++-- > src/qemu/qemu_block.h | 1 + > src/qemu/qemu_monitor.c | 9 +++++---- > src/qemu/qemu_monitor.h | 3 ++- > src/qemu/qemu_monitor_json.c | 4 ++-- > src/qemu/qemu_monitor_json.h | 3 ++- > tests/qemumonitorjsontest.c | 2 +- I also think that there's a bit too much going on in this patch. I'd prefer if you first modify the monitor code. In a separate patch then modify the qemu_block.c code. Also qemuBlockCommitImpl is missing a function comment explaining what the values are and in the instance of this commit when it is supposed to be used.
