On Thu, Aug 25, 2022 at 09:03:46AM +0200, Martin Kletzander wrote:
> When commit bac6b266fb6a added this "functionality" this was the only
> naming I could think of, but after discussion with Dan we found the name
> 'null' fits a bit better, so change it before we make a release with the
> old name.
>
> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> ---
> NEWS.rst | 2 +-
> docs/formatdomain.rst | 4 ++--
> src/ch/ch_monitor.c | 2 +-
> src/conf/domain_conf.c | 20 +++++++++----------
> src/conf/domain_conf.h | 2 +-
> src/conf/netdev_bandwidth_conf.c | 2 +-
> src/conf/schemas/domaincommon.rng | 2 +-
> src/libxl/libxl_conf.c | 2 +-
> src/libxl/xen_common.c | 2 +-
> src/lxc/lxc_controller.c | 2 +-
> src/lxc/lxc_driver.c | 6 +++---
> src/lxc/lxc_process.c | 4 ++--
> src/qemu/qemu_command.c | 8 ++++----
> src/qemu/qemu_domain.c | 2 +-
> src/qemu/qemu_hotplug.c | 6 +++---
> src/qemu/qemu_interface.c | 4 ++--
> src/qemu/qemu_process.c | 4 ++--
> src/qemu/qemu_validate.c | 2 +-
> src/vmx/vmx.c | 4 ++--
> .../{ethernet-dummy.vmx => ethernet-null.vmx} | 0
> .../{ethernet-dummy.xml => ethernet-null.xml} | 2 +-
> tests/vmx2xmltest.c | 2 +-
> ...et-dummy.vmx => xml2vmx-ethernet-null.vmx} | 0
> ...et-dummy.xml => xml2vmx-ethernet-null.xml} | 2 +-
> tests/xml2vmxtest.c | 2 +-
> tools/virsh-domain.c | 2 +-
> 26 files changed, 45 insertions(+), 45 deletions(-)
> rename tests/vmx2xmldata/{ethernet-dummy.vmx => ethernet-null.vmx} (100%)
> rename tests/vmx2xmldata/{ethernet-dummy.xml => ethernet-null.xml} (95%)
> rename tests/xml2vmxdata/{xml2vmx-ethernet-dummy.vmx => xml2vmx-ethernet-null.vmx} (100%)
> rename tests/xml2vmxdata/{xml2vmx-ethernet-dummy.xml => xml2vmx-ethernet-null.xml} (90%)
Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
