On Wed, Aug 10, 2022 at 05:16:57PM +0200, Christophe de Dinechin wrote: > On 2022-08-10 at 16:29 +02, Andrea Bolognani <abologna@xxxxxxxxxx> wrote... > > We need to mock the function that probes for HVF support. > > > > Andrea Bolognani (3): > > tests: Use domaincapsmock in qemucapabilitiestest > > qemu: Make virQEMUCapsProbeHVF() non-static > > tests: Mock virQEMUCapsProbeHVF() > > > > src/qemu/qemu_capabilities.c | 4 ++-- > > src/qemu/qemu_capabilities.h | 2 ++ > > tests/domaincapsmock.c | 6 ++++++ > > tests/qemucapabilitiestest.c | 3 ++- > > 4 files changed, 12 insertions(+), 3 deletions(-) > > This works. We now have a clean test suite on macOS 12: > > Ok: 252 > Expected Fail: 0 > Fail: 0 > Unexpected Pass: 0 > Skipped: 19 > Timeout: 0 > > For the series: > > Reviewed-by: Christophe de Dinechin <dinechin@xxxxxxxxxx> > Tested-by: Christophe de Dinechin <dinechin@xxxxxxxxxx> Thanks to both you and Jano! Pushed now. I'll try switching the Cirrus CI configuration to macOS 12 again, but I'm afraid it's still going to hit the qemuxml2argvtest issue that doesn't show up on your machine. We'll see :) -- Andrea Bolognani / Red Hat / Virtualization
