On Tue, Jul 26, 2022 at 04:37:50PM +0200, Peter Krempa wrote:
> While we assume that -blockdev is supported the validator had also some
> corner cases for -drive. Since we use '-drive' exclusively for the
> extremely rarely used SD cards it makes no sense to have the validation.
>
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
> src/qemu/qemu_domain.c | 60 +++---------------------------------------
> 1 file changed, 3 insertions(+), 57 deletions(-)
>
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index 8997041b34..0839744660 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
[...]
> @@ -4961,11 +4922,9 @@ qemuDomainValidateStorageSource(virStorageSource *src,
> return -1;
> }
>
> - /* TFTP protocol was not supported for some time, lock it out at least with
> - * -blockdev */
> + /* TFTP protocol was not supported */
I would change the comment to 'TFTP protocol is not supported since QEMU
2.8.0'
> if (actualType == VIR_STORAGE_TYPE_NETWORK &&
> - src->protocol == VIR_STORAGE_NET_PROTOCOL_TFTP &&
> - blockdev) {
> + src->protocol == VIR_STORAGE_NET_PROTOCOL_TFTP) {
> virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> _("'tftp' protocol is not supported with this QEMU binary"));
> return -1;
Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
