Re: [PATCH 70/80] qemuDomainDiskBlockJobIsSupported: Assume QEMU_CAPS_BLOCKDEV is supported

[Ján Tomko <jtomko@xxxxxxxxxx>]

On a Tuesday in 2022, Peter Krempa wrote:
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
> src/qemu/qemu_backup.c     |  2 +-
> src/qemu/qemu_checkpoint.c |  2 +-
> src/qemu/qemu_domain.c     | 10 +++-------
> src/qemu/qemu_domain.h     |  3 +--
> src/qemu/qemu_driver.c     |  6 +++---
> src/qemu/qemu_snapshot.c   | 13 +++++--------
> 6 files changed, 14 insertions(+), 22 deletions(-)
>
> diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c
> index b90185a375..60cb79d70d 100644
> --- a/src/qemu/qemu_backup.c
> +++ b/src/qemu/qemu_backup.c
> @@ -260,7 +260,7 @@ qemuBackupDiskPrepareDataOne(virDomainObj *vm,
>         return -1;
>     }
>
> -    if (!qemuDomainDiskBlockJobIsSupported(vm, dd->domdisk))
> +    if (!qemuDomainDiskBlockJobIsSupported(dd->domdisk))
>         return -1;
>
>     if (dd->store->format == VIR_STORAGE_FILE_NONE) {
> diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c
> index 933ea41023..98e1a94def 100644
> --- a/src/qemu/qemu_checkpoint.c
> +++ b/src/qemu/qemu_checkpoint.c
> @@ -372,7 +372,7 @@ qemuCheckpointPrepare(virQEMUDriver *driver,
>             return -1;
>         }
>
> -        if (!qemuDomainDiskBlockJobIsSupported(vm, vm->def->disks[i]))
> +        if (!qemuDomainDiskBlockJobIsSupported(vm->def->disks[i]))
>             return -1;
>     }
>
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index fb29135179..8999f58d20 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -11349,19 +11349,15 @@ qemuDomainInitializePflashStorageSource(virDomainObj *vm,
> /**
>  * qemuDomainDiskBlockJobIsSupported:
>  *
> - * Returns true if block jobs are supported on @disk by @vm or false and reports
> + * Returns true if block jobs are supported on @disk orfalse and reports

*or false

>  * an error otherwise.
>  *
>  * Note that this does not verify whether other block jobs are running etc.
>  */
> bool

Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature