Re: [libvirt PATCH for 8.6.0] qemu_migration_params: Avoid deadlock in qemuMigrationParamsReset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/28/22 16:01, Jiri Denemark wrote:
> In my recent comnmit v8.5.0-188-gc47f1abb81 I accidentally moved
> qemuMigrationParamsResetTLS after qemuDomainObjEnterMonitorAsync not
> noticing qemuMigrationParamsResetTLS will try to enter the monitor
> again. The second call will time out and return with a domain object
> locked. But we're still in monitor section and the object should be
> unlocked which means qemuDomainObjExitMonitor will deadlock trying to
> lock it again.
> 
> Fixes: c47f1abb81194461377a0c608a7ecd87f9ce9146
> Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> ---
>  src/qemu/qemu_migration_params.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)


Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux