> -----Original Message-----
> From: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> Sent: Thursday, July 28, 2022 4:36 PM
> To: Peter Krempa <pkrempa@xxxxxxxxxx>
> Cc: Michal Privoznik <mprivozn@xxxxxxxxxx>; libvir-list@xxxxxxxxxx; Yang,
> Lin A <lin.a.yang@xxxxxxxxx>; Ding, Jian-feng <jian-feng.ding@xxxxxxxxx>;
> Huang, Haibin <haibin.huang@xxxxxxxxx>
> Subject: Re: [PATCH v14 07/15] domain_capabilities: Define SGX capabilities
> structs
>
> On Thu, Jul 28, 2022 at 10:04:23AM +0200, Peter Krempa wrote:
> > On Wed, Jul 27, 2022 at 12:34:53 +0200, Michal Privoznik wrote:
> > > From: Haibin Huang <haibin.huang@xxxxxxxxx>
> > >
> > > Signed-off-by: Haibin Huang <haibin.huang@xxxxxxxxx>
> > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> > > ---
> > > src/conf/domain_capabilities.c | 11 +++++++++++
> > > src/conf/domain_capabilities.h | 22 ++++++++++++++++++++++
> > > src/libvirt_private.syms | 1 +
> > > 3 files changed, 34 insertions(+)
> >
> > [...]
> >
> > > diff --git a/src/conf/domain_capabilities.h
> > > b/src/conf/domain_capabilities.h index a526969cda..e4654a65cd 100644
> > > --- a/src/conf/domain_capabilities.h
> > > +++ b/src/conf/domain_capabilities.h
> > > @@ -193,6 +193,22 @@ struct _virSEVCapability {
> > > unsigned int max_es_guests;
> > > };
> > >
> > > +typedef struct _virSection virSection;
> >
> > This name feels a bit too generic and not much reusable. On the other
> > hand changing it feels pointless.
>
> Clearly it should be virSGXSection
[Haibin] good idea, I will modify it.
>
> With regards,
> Daniel
> --
> |: https://berrange.com -o-
> https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o-
> https://www.instagram.com/dberrange :|
