On 7/26/22 16:16, Daniel P. Berrangé wrote: > On Mon, Jul 25, 2022 at 03:40:41PM +0200, Michal Prívozník wrote: >> On 7/22/22 18:23, Daniel P. Berrangé wrote: >>> This is to enable SEV builds of UEFI which provide only a single CODE.fd >>> file, with not VARS.fd. >>> >>> Daniel P. Berrangé (2): >>> conf: support stateless UEFI firmware >>> qemu: support use of stateless EFI firmware >>> >>> docs/formatdomain.rst | 9 +++- >>> src/conf/domain_conf.c | 9 ++++ >>> src/conf/domain_conf.h | 1 + >>> src/conf/domain_validate.c | 26 ++++++++++ >>> src/conf/schemas/domaincommon.rng | 5 ++ >>> src/qemu/qemu_domain.c | 3 +- >>> src/qemu/qemu_firmware.c | 48 +++++++++++-------- >>> ...-auto-bios-not-stateless.x86_64-latest.err | 1 + >>> .../firmware-auto-bios-not-stateless.xml | 18 +++++++ >>> ...are-auto-bios-stateless.x86_64-latest.args | 32 +++++++++++++ >>> .../firmware-auto-bios-stateless.xml | 18 +++++++ >>> ...ware-auto-efi-stateless.x86_64-latest.args | 33 +++++++++++++ >>> .../firmware-auto-efi-stateless.xml | 18 +++++++ >>> .../firmware-manual-bios-not-stateless.err | 1 + >>> .../firmware-manual-bios-not-stateless.xml | 15 ++++++ >>> .../firmware-manual-bios-stateless.args | 30 ++++++++++++ >>> .../firmware-manual-bios-stateless.xml | 15 ++++++ >>> ...nual-efi-nvram-stateless.x86_64-latest.err | 1 + >>> .../firmware-manual-efi-nvram-stateless.xml | 21 ++++++++ >>> ...nvram-template-stateless.x86_64-latest.err | 1 + >>> ...re-manual-efi-nvram-template-stateless.xml | 19 ++++++++ >>> ...re-manual-efi-stateless.x86_64-latest.args | 33 +++++++++++++ >>> .../firmware-manual-efi-stateless.xml | 18 +++++++ >>> tests/qemuxml2argvtest.c | 10 ++++ >>> ...ware-auto-bios-stateless.x86_64-latest.xml | 34 +++++++++++++ >>> .../firmware-manual-bios-stateless.xml | 25 ++++++++++ >>> .../firmware-manual-bios.xml | 25 ++++++++++ >>> tests/qemuxml2xmltest.c | 3 ++ >>> 28 files changed, 451 insertions(+), 21 deletions(-) >>> create mode 100644 tests/qemuxml2argvdata/firmware-auto-bios-not-stateless.x86_64-latest.err >>> create mode 100644 tests/qemuxml2argvdata/firmware-auto-bios-not-stateless.xml >>> create mode 100644 tests/qemuxml2argvdata/firmware-auto-bios-stateless.x86_64-latest.args >>> create mode 100644 tests/qemuxml2argvdata/firmware-auto-bios-stateless.xml >>> create mode 100644 tests/qemuxml2argvdata/firmware-auto-efi-stateless.x86_64-latest.args >>> create mode 100644 tests/qemuxml2argvdata/firmware-auto-efi-stateless.xml >>> create mode 100644 tests/qemuxml2argvdata/firmware-manual-bios-not-stateless.err >>> create mode 100644 tests/qemuxml2argvdata/firmware-manual-bios-not-stateless.xml >>> create mode 100644 tests/qemuxml2argvdata/firmware-manual-bios-stateless.args >>> create mode 100644 tests/qemuxml2argvdata/firmware-manual-bios-stateless.xml >>> create mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-nvram-stateless.x86_64-latest.err >>> create mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-nvram-stateless.xml >>> create mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-nvram-template-stateless.x86_64-latest.err >>> create mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-nvram-template-stateless.xml >>> create mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-stateless.x86_64-latest.args >>> create mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-stateless.xml >>> create mode 100644 tests/qemuxml2xmloutdata/firmware-auto-bios-stateless.x86_64-latest.xml >>> create mode 100644 tests/qemuxml2xmloutdata/firmware-manual-bios-stateless.xml >>> create mode 100644 tests/qemuxml2xmloutdata/firmware-manual-bios.xml >>> >> >> Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > > ANy objection to me pushing this now, or wait until after freeze is > over ? Yeah, this is safe for freeze. Michal