Re: [PATCH 0/5] qemu: Migration code (ternary operator) cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/25/22 14:45, Peter Krempa wrote:
> I've noticed few things that could be improved during review of Jirka's
> post copy migration changes but didn't want to interfer with the series
> at that point.
> 
> Peter Krempa (5):
>   qemuMigrationDstFinishFresh: Avoid multi-line ternary operator in
>     function call
>   qemuMigrationDstPersist: Avoid multi-line ternary operator in function
>     call
>   qemu: migration: Overwrite 'dname' only when NULL
>   qemuMigrationSrcIOFunc: Avoid unnecessary string construction
>   qemu: monitor: Split up enum strings definitions
> 
>  src/qemu/qemu_migration.c | 37 +++++++++++++++++++++++--------------
>  src/qemu/qemu_monitor.c   | 35 ++++++++++++++++++++++++++---------
>  2 files changed, 49 insertions(+), 23 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

But see my comment to 1/5 before pushing. There's one typo that needs
fixing.

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux