On Fri, Jul 08, 2022 at 15:01:50 +0200, Michal Privoznik wrote:
> Historically, the dumpxml command reject any unknown arguments,
> for instance:
>
> virsh dumpxml fedora xxx
>
> However, after v8.5.0-rc1~31 the second argument ('xxx') is
> treated as an XPath, but it's not that clearly visible.
> Therefore, require the --xpath switch, like this:
>
> virsh dumpxml fedora --xpath xxx
>
> Yes, this breaks already released virsh, but I think we can argue
> that the pool of users of this particular function is very small.
> We also document the argument being mandatory:
>
> dumpxml [--inactive] [--security-info] [--update-cpu] [--migratable]
> [--xpath EXPRESSION] [--wrap] domain
>
> The sooner we do this change, the better.
>
> The same applies for other *dumpxml functions (net-dumpxml,
> pool-dumpxml, vol-dumpxl to name a few).
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2103524
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
